feat: migrate back to prost#6363
Draft
jxs wants to merge 9 commits intolibp2p:masterfrom
Draft
Conversation
|
Note that there exists a pure Rust Protobuf compiler as a library for use with Not my crate but been using it for a while and it's worked great so far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #3312, we migrated from
prosttoquick-protobufprimarily to eliminate the need for theprotocdependency on CI for generating Rust code from.protofiles, as we were not versioning them at the time.However,
quick-protobufhas been unmaintained for years, and we should transition to a more actively maintained protobuf implementation. By versioning the generated Rust code from the.protofiles, we can limit the need forprotocto only when the.protofiles are modified and the Rust code needs to be regenerated.To address this, @macladson has generously taken the time to draft a migration plan to move us back to
prost.